This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Use <a> element to parse url instead of Regexp #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaweet
suggested changes
Jun 16, 2017
There was a problem hiding this comment.
Thank you @alepop for the PR. It's much better than my original solution, though it still doesn't work well on the reported input (liskwallet.punkrock.me). <a> element treats it as local path. In electron wrapper, it connects to a mainnet peer. On localhost:8080 it tries to connect to localhost:8080.
|
@slaweet yep. It is a basic behavior for nonvalid URL format. if you pass a string that not represent the URL the |
karmacoma
added
invalid
and removed
bug
enhancement
refactoring
test
update
✅ ready
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There an error when parsing the wrong URL with regexp.
fix #417